copy the plugins only if the plugins directory is empty in JENKINS_HOME #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @lordofthejars |
|
LGTM, now let's try if when it is unidled if it still happens or not |
|
Looks like this was done kind of explicitly. I wonder why. lordofthejars@fa9ce3e |
|
@jaseemabid I was also wondering the same and I suspect if we install or remove new plugins they might not get reflected, but I am not 100% sure hence raised this PR and plan to test it. but need to think how can I test if we add/remove plugins will it reflect back or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jenkins copies the plugins on every time and deletes the plugins, disabled this behavior.
This PR is related openshiftio/openshift.io#2612